Missing misra rule-text-file should still allow for the analysis#4458
Merged
orbitcowboy merged 1 commit intocppcheck-opensource:mainfrom Sep 12, 2022
Merged
Conversation
dzid26
changed the title
danmar
approved these changes
Sep 10, 2022
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
looks good to me. If all the CI will be green it's OK for me to merge.
Collaborator
|
have you contributed to Cppcheck before? If not.. I would like to know which name you would like to get added in the AUTHORS file. |
Contributor
Author
|
I haven't contributed before. You can add: Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed error throwing when misra rules text file is missing. If the file is present the rules text will be displayed, if not it will let the user know the file is missing.
This improves the experience when misra.json is distributed together with a project.
Currently, in order not to break static analysis checker configuration (in my case realtime editor checker flylint), I need to provide dummy rules file (due to licensing). But that gets annoying for version control, when the file is replaced locally with proper rules file. This change allows to remove the dummy file from version control. Now whoever owns the rule file, can just drop it in the project path and get the proper violations output.