Fix #11301 debug: constStatementError not handled.#4463
Merged
orbitcowboy merged 2 commits intocppcheck-opensource:mainfrom Sep 14, 2022
Merged
Fix #11301 debug: constStatementError not handled.#4463orbitcowboy merged 2 commits intocppcheck-opensource:mainfrom
orbitcowboy merged 2 commits intocppcheck-opensource:mainfrom
Conversation
firewave
reviewed
Sep 14, 2022
| if (tok->varId() != 0) | ||
| return true; | ||
| if (Token::Match(tok, "%bool%|%num%|%str%|%char%|nullptr|NULL")) | ||
| if (Token::Match(tok, constantMatchStr)) |
Collaborator
There was a problem hiding this comment.
Making it a variable prevents matchcompiling. Same below.
Collaborator
Author
There was a problem hiding this comment.
Should we make it a #define instead?
Collaborator
There was a problem hiding this comment.
That's won't help either. The matchcompiler looks for inline strings and "compiles" them. No macro support.
It would help a non-matchcompiled build a bit though.
You could deduplicate the whole function call with a static one instead of just the string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.