lib/sourcelocation.h: add missing <cstdint> include

[trofi]

Without the change build on upcoming gcc-13 fails as:

In file included from lib/symboldatabase.h:28,
                 from lib/astutils.h:36,
                 from test/testastutils.cpp:20:
lib/sourcelocation.h:52:10: error: 'uint_least32_t' in namespace 'std' does not name a type
   52 |     std::uint_least32_t m_line = 0;
      |          ^~~~~~~~~~~~~~

[firewave]

Thanks for your contribution.

Strange. I just did a run of include-what-you-use and that didn't come up. I just tested it with a reduced case and it is being reported. Something to look into.

We should only include it when needed. But that can be adjusted in later changes.

[trofi]

I'm not sure how include-what-you-use tracks indirect includes for type declarations. AFAIU uint_least32_t should come out of <cstdint> (or it's wrapper). I did not notice any header wrappers in cppcpeck, but I did not look too closely.

Why it came up only now: in gcc before 13 <string> happened to include <cstdint> for it's own internals. But after a cleanup gcc-13 removed the include. This exposed missing header include in a number of projects including cppcheck. https://gcc.gnu.org/gcc-13/porting_to.html mentions header changes as well.

[trofi]

Oh, I probably misumderstood your comment about "when needed". I'll move the header under:

#else
struct SourceLocation {
    static SourceLocation current() {

[trofi]

Moved #include into #ifdef branch that uses the types directly.

[firewave]

Moved #include into #ifdef branch that uses the types directly.

Yeah - that's what I meant. Thanks!

I'm not sure how include-what-you-use tracks indirect includes for type declarations. AFAIU uint_least32_t should come out of <cstdint> (or it's wrapper). I did not notice any header wrappers in cppcpeck, but I did not look too closely.

It's a limitation of include-what-you-use: include-what-you-use/include-what-you-use#1035.

Fortunately just recently CMake added a feature which allows us to handle it.

Why it came up only now: in gcc before 13 <string> happened to include <cstdint> for it's own internals. But after a cleanup gcc-13 removed the include. This exposed missing header include in a number of projects including cppcheck. https://gcc.gnu.org/gcc-13/porting_to.html mentions header changes as well.

We came across this multiple times in the past which is why older versions of Cppcheck cannot be built with the latest toolchains. But we no longer rely on transitive includes (apparently we still do) so it should be better now.