avoid some unnecessary object creations and copies

[firewave]

No description provided.

[firewave]

This regressed the callgrind step in the CI from 85,414,145,406 to 85,422,952,324.

[firewave]

The regression is caused by 92c08d1.

In ErrorMessage::toString() there is a readCode() call which didn't happen before.

This happens because the ErrorMessage::FileLocation constructor is setting ErrorMessage::FileLocation::mOrigFileName whereas ErrorMessage::FileLocation::setfile() isn't.

ErrorMessage::FileLocation::setfile() also does sanitization of the path but the constructor doesn't.

@danmar Is this intentional?

[danmar]

This happens because the ErrorMessage::FileLocation constructor is setting ErrorMessage::FileLocation::mOrigFileName whereas ErrorMessage::FileLocation::setfile() isn't.

Spontanously my feeling is that this might be intentional. But I'd need to dig into the code to know.

ErrorMessage::FileLocation::setfile() also does sanitization of the path but the constructor doesn't.

not sure if sanitization is needed. but if it is then the constructor should probably also do it.