Skip to content

coverage.yml: updated codecov/codecov-action to v3#4501

Merged
orbitcowboy merged 1 commit intocppcheck-opensource:mainfrom
firewave:codecov
Sep 24, 2022
Merged

coverage.yml: updated codecov/codecov-action to v3#4501
orbitcowboy merged 1 commit intocppcheck-opensource:mainfrom
firewave:codecov

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

v1 has been deprecated and is considered "no longer function[ing]" since February - see https://github.com/codecov/codecov-action#%EF%B8%8F--deprecation-of-v1

@firewave
Copy link
Copy Markdown
Collaborator Author

As a side note. I think we could limit the coverage generation to the main branch. We have not integrated this with PRs (if even possible) and I guess nobody is using this to check the coverage before a PR is being flagged as "ready". Also the external and test folder should be excluded. And looking at the report it seems like some data is missing - although all necessary info about the coverage is there.

@firewave firewave marked this pull request as ready for review September 23, 2022 20:51
@orbitcowboy orbitcowboy merged commit 872be65 into cppcheck-opensource:main Sep 24, 2022
@firewave firewave deleted the codecov branch September 24, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants