Skip to content

Fix #11362 FP returnDanglingLifetime for pointer to struct member in static array #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbitcowboy merged 2 commits into from
Oct 21, 2022
Merged

Fix #11362 FP returnDanglingLifetime for pointer to struct member in static array #4563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1868dcc
Fix #11362 FP returnDanglingLifetime for pointer to struct member in…
chrchr-github Oct 21, 2022
aa172ea
Undo
chrchr-github Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ static bool isInScope(const Token * tok, const Scope * scope)
const Variable * var = tok->variable();
if (var && (var->isGlobal() || var->isStatic() || var->isExtern()))
return false;
if (tok->scope() && tok->scope()->isNestedIn(scope))
if (tok->scope() && !tok->scope()->isClassOrStructOrUnion() && tok->scope()->isNestedIn(scope))
return true;
if (!var)
return false;
Expand Down
7 changes: 7 additions & 0 deletions test/testautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3050,6 +3050,13 @@ class TestAutoVariables : public TestFixture {
" return std::tie(xs[i]...);\n"
"}\n");
ASSERT_EQUALS("", errout.str());

// #11362
check("int* f() {\n"
" static struct { int x; } a[] = { { 1 } };\n"
" return &a[0].x;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}

void danglingLifetimeFunction() {
Expand Down