avoid some unnecessary copies#4589
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Dec 18, 2022
Merged
Conversation
Collaborator
Author
|
This was an intentional draft since I have not profiled the changes yet (although they should not have much impact). |
Collaborator
Author
|
The callgrind execution in the CI shows a very slightly regression but it is caused by increased instruction counts for libc calls. The affected code is not related to those changes. I also saw this when comparing earlier revisions. It appears to be an issue with callgrind though - see llvm/llvm-project#53587. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while looking into the fixes for the upcoming
performance-unnecessary-copy-on-last-useclang-tidy check.