Skip to content

greatly sped up dmake#4630

Merged
orbitcowboy merged 5 commits intocppcheck-opensource:mainfrom
firewave:dmake
Dec 17, 2022
Merged

greatly sped up dmake#4630
orbitcowboy merged 5 commits intocppcheck-opensource:mainfrom
firewave:dmake

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Dec 12, 2022

For some reason which I have not figured out yet dmake got much slower. Since it is a fixed dependency in CMake builds it slows things down quite a bit. These changes greatly improve the run-time of it without changing the output.

We still show figure out when it got slow to fix the actual root cause.

Before:

Benchmark 1: ./dmake
  Time (mean ± σ):     12.244 s ±  0.727 s    [User: 0.571 s, System: 11.501 s]
  Range (min … max):   11.643 s … 13.440 s    5 runs

After:

Benchmark 1: ./dmake
  Time (mean ± σ):      1.081 s ±  0.101 s    [User: 0.162 s, System: 0.911 s]
  Range (min … max):    0.989 s …  1.251 s    5 runs

This was tested using GCC 12 on WSL1 Kali Linux.

@firewave firewave changed the title sped up dmake greatly sped up dmake Dec 12, 2022
@firewave firewave marked this pull request as ready for review December 12, 2022 16:36
@orbitcowboy orbitcowboy merged commit e572103 into cppcheck-opensource:main Dec 17, 2022
@firewave firewave deleted the dmake branch December 17, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants