Skip to content

Fix #11289 FP wrongPrintfScanfArgNum - snprintf with parameter pack #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbitcowboy merged 3 commits into from
Dec 15, 2022
+13 −0
Merged

Fix #11289 FP wrongPrintfScanfArgNum - snprintf with parameter pack #4644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c399f7
Fix #11289 FP wrongPrintfScanfArgNum - snprintf with parameter pack
chrchr-github Dec 14, 2022
cfae4b5
Merge branch 'danmar:main' into chr_Fix11289
chrchr-github Dec 14, 2022
39b66c2
Merge branch 'danmar:main' into chr_Fix11289
chrchr-github Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/checkio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,6 +1306,8 @@ void CheckIO::checkFormatString(const Token * const tok,
// Count printf/scanf parameters..
int numFunction = 0;
while (argListTok2) {
if (Token::Match(argListTok2, "%name% ...")) // bailout for parameter pack
return;
numFunction++;
argListTok2 = argListTok2->nextArgument(); // Find next argument
}
Expand Down
11 changes: 11 additions & 0 deletions test/testio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class TestIO : public TestFixture {
TEST_CASE(testPrintfAuto); // #8992
TEST_CASE(testPrintfParenthesis); // #8489
TEST_CASE(testStdDistance); // #10304
TEST_CASE(testParameterPack); // #11289
}

#define check(...) check_(__FILE__, __LINE__, __VA_ARGS__)
Expand Down Expand Up @@ -4868,6 +4869,16 @@ class TestIO : public TestFixture {
"}", /*inconclusive*/ false, /*portability*/ true);
ASSERT_EQUALS("", errout.str());
}

void testParameterPack() { // #11289
check("template <typename... Args> auto f(const char* format, const Args&... args) {\n"
" return snprintf(nullptr, 0, format, args...);\n"
"}\n"
"void g() {\n"
" f(\"%d%d\", 1, 2);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
};

REGISTER_TEST(TestIO)