Improve qt.cfg: unreadVariable for macro parameter

[chrchr-github]

Not sure why #include <QTest> is not found.

[firewave]

/home/runner/work/cppcheck/cppcheck/test/cfg/qt.cpp:22:10: fatal error: QtTest: No such file or directory

It is called QTest - mind the extranous t.

[chrchr-github]

/home/runner/work/cppcheck/cppcheck/test/cfg/qt.cpp:22:10: fatal error: QtTest: No such file or directory

It is called QTest - mind the extranous t.

Well, that's what I tried first, with the same result. I suspect that a Qt module is missing somehow.

[firewave]

In test/cfg/runtests.sh you have to add Qt5Test to the two pkg-config calls in function qt_fn.

[firewave]

In test/cfg/runtests.sh you have to add Qt5Test to the two pkg-config calls in function qt_fn.

Oh, I see that you already did that. Lemme try that locally.

[chrchr-github]

Like so? (Commit was reverted, then un-reverted)

[chrchr-github]

In test/cfg/runtests.sh you have to add Qt5Test to the two pkg-config calls in function qt_fn.

Oh, I see that you already did that. Lemme try that locally.

Thanks, I don't have access to a similar system right now.

[firewave]

Found the actual issue. function get_pkg_config_cflags only passes the first parameter along. You need to change $1 tp $* for it to pass all parameters to the underlying call.

[chrchr-github]

Awesome, that did it...

[firewave]

If you add quotes you need to use "$@" instead of "$*" so the parameters stay individual ones - that also what shellcheck suggested:

In ./test/cfg/runtests.sh line 36:
    PKGCONFIG=$(pkg-config --cflags $*)
                                    ^-- SC2048: Use "$@" (with quotes) to prevent whitespace problems.

[chrchr-github]

Fixed, but seemed to work nonetheless.