test-my-pr robustification#4756
Merged
firewave merged 2 commits intocppcheck-opensource:mainfrom Jan 31, 2023
Merged
Conversation
Occasionally, get_packages_count() fails, which is a bit annoying since it happens after compilation and therefore can take some time to detect. Add try-retry to the function to make it more robust.
Moving it to the library means test-my-pr also benefits from it. This fixes Trac ticket #11405.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
test-my-pr.pya little more robust by retrying ifget_package()orget_package_count()fails. Forget_package(), this meant moving the retry-logic already present indonate-cputo the library (this fixes trac ticket #11045). Forget_package_count(), which is only used intest-my-pr, this meant adding the retry-logic to the function.