Skip to content

made Platform a member of Settings instead of inheriting from it / cleanups#4791

Merged
danmar merged 4 commits intocppcheck-opensource:mainfrom
firewave:platform-s
Mar 3, 2023
Merged

made Platform a member of Settings instead of inheriting from it / cleanups#4791
danmar merged 4 commits intocppcheck-opensource:mainfrom
firewave:platform-s

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

I wanted to make Platform::Type an eum class but that caused problems with assertions (which use streaming operators) and the GUI code.

@firewave firewave force-pushed the platform-s branch 3 times, most recently from ef9a4b4 to 86dc43b Compare February 13, 2023 17:34
@firewave
Copy link
Copy Markdown
Collaborator Author

I filed https://trac.cppcheck.net/ticket/11559 about the previously hidden functionConst warnings.

@firewave firewave force-pushed the platform-s branch 3 times, most recently from 5e88647 to fc0cb4f Compare March 2, 2023 23:24
@firewave firewave marked this pull request as draft March 2, 2023 23:35
@firewave firewave marked this pull request as ready for review March 3, 2023 10:04
@danmar danmar merged commit 5af6ca6 into cppcheck-opensource:main Mar 3, 2023
@firewave firewave deleted the platform-s branch March 3, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants