token.cpp: removed unreachable cases from multiComparePercent()#4814
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Feb 23, 2023
Merged
token.cpp: removed unreachable cases from multiComparePercent()#4814danmar merged 1 commit intocppcheck-opensource:mainfrom
multiComparePercent()#4814danmar merged 1 commit intocppcheck-opensource:mainfrom
Conversation
Collaborator
Author
|
I filed https://trac.cppcheck.net/ticket/11575 about detecting dead switch cases. |
Collaborator
Author
|
Running Clang 15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calling function
multiCompare()already explicitly checks that those characters are not present so we don't need to handle them in the switch.It also seems to lead to better inlining and improve the performance by a few percent.