Fix #11577 FN unusedStructMember when casting address (regression, reverts #10684)#4816
Merged
firewave merged 1 commit intocppcheck-opensource:mainfrom Apr 4, 2023
Merged
Conversation
pfultz2
approved these changes
Feb 24, 2023
Collaborator
|
I am not sure how "reasonable" it would be to show the warning for #10684 again. The code looks like an extremely simple serialization. So depending on how many fields are in the struct you would need to annotate each with a suppression which would seem very FP-ish. As it was not reported from an external source I think it might be fine to revert the change and re-visit it when a report emerges. We should note the revert in the ticket though. |
chrchr-github
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think showing a warning for the code from #10684 is reasonable.