removed TokenList::getSettings() and replaced usage in ValueFlow with provided settings#4843
Merged
danmar merged 3 commits intocppcheck-opensource:mainfrom Mar 3, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only used in
valueflow.cppwhere we already have theSettingsavailable so just use those instead. It might have returnednullptr(although not in the context where the ValueFlow is called) and was immediately dereferenced unchecked.It is unlikely (as there only is one
Settingsobject) but it might have also led to two different settings being used within the ValueFlow.