Skip to content

refs #11603 - deprecated --enable=information implicitly enabling missingInclude#4865

Merged
danmar merged 2 commits intocppcheck-opensource:mainfrom
firewave:missinginclude
Mar 9, 2023
Merged

refs #11603 - deprecated --enable=information implicitly enabling missingInclude#4865
danmar merged 2 commits intocppcheck-opensource:mainfrom
firewave:missinginclude

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Mar 6, 2023

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Mar 6, 2023

I would prefer to simply remove this dependency since most people might have never seen any of these warnings before because of https://trac.cppcheck.net/ticket/11283 which was just fixed in this dev cycle. But some people might have always run this with only a single job because of system limitations or a certain use case which does not require it or doesn't make sense for (IDE integration comes to mind) So I do not think that we should simply change the behavior.

https://trac.cppcheck.net/ticket/11603 shows that might have a sudden unexpected effect but it can be worked around easily and there might be cases (as in the ticket) where this will actually expose flawed configurations of the analysis which might lead to false positives and false negatives.

So at the end we should have more consistency, transparency, usability and hopefully even better results.

On a side note: I hope to get all the deprecations we should do into this dev cycle so people have one point where they have to change their configurations and we don't need them to do adjustments with several releases. Also I chose a shorter span for Windows-only stuff as those users can more easily update to a newer version (and possibly have to do it manually anyways as no common packaging system) whereas general or Linux-specific changes should have a longer period as people might have to rely on their distro providing an update and that might just happen when an actual new distro version drops which is usually around 6 months. There could be the way of a Snap or Flatpak package but the first is totally out-of-date and not provided by us and I am not aware of the latter. Something to look into via https://trac.cppcheck.net/ticket/10772. I could have published all of them already but since they all touch releasenotes.txt they would all conflict with each other and would need to be rebased when another one got merged.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Mar 7, 2023

This also partially fixes https://trac.cppcheck.net/ticket/10697

@danmar danmar merged commit 3013183 into cppcheck-opensource:main Mar 9, 2023
@firewave firewave deleted the missinginclude branch March 9, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants