Skip to content

Fix 11557: FP derefInvalidIteratorRedundantCheck in and/or condition #4892

Merged
firewave merged 5 commits into
cppcheck-opensource:mainfrom
pfultz2:valueflow-cond-add-impossible-incondition
Mar 16, 2023
Merged

Fix 11557: FP derefInvalidIteratorRedundantCheck in and/or condition #4892
firewave merged 5 commits into
cppcheck-opensource:mainfrom
pfultz2:valueflow-cond-add-impossible-incondition

Conversation

@pfultz2
Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 commented Mar 13, 2023

No description provided.

@pfultz2
Copy link
Copy Markdown
Contributor Author

pfultz2 commented Mar 14, 2023

This only fails codecov, but I dont know what the missing code coverage is.

Comment thread lib/valueflow.cpp Outdated
@chrchr-github
Copy link
Copy Markdown
Collaborator

Codecov is not making a good first impression, see #4891. Those automatic comments are also annoying.

@firewave
Copy link
Copy Markdown
Collaborator

Codecov is not making a good first impression, see #4891. Those automatic comments are also annoying.

It is mainly distracting, yes. I will try to get on top of this soon.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4892 (74eff8d) into main (61e8b84) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #4892      +/-   ##
==========================================
- Coverage   91.48%   91.45%   -0.03%     
==========================================
  Files         201      201              
  Lines      110766   110840      +74     
==========================================
+ Hits       101335   101373      +38     
- Misses       9431     9467      +36     
Flag Coverage Δ
unittests 91.45% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/valueflow.cpp 93.24% <100.00%> (+<0.01%) ⬆️
test/teststl.cpp 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Collaborator

@chrchr-github chrchr-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firewave
Copy link
Copy Markdown
Collaborator

This only fails codecov, but I dont know what the missing code coverage is.

It is a bug with codecov - apparently a long-standing one which never got resolved.

@firewave firewave merged commit 8324caf into cppcheck-opensource:main Mar 16, 2023
@pfultz2 pfultz2 deleted the valueflow-cond-add-impossible-incondition branch March 16, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants