Skip to content

Fix #11621 FP functionConst when assigning init list#4895

Merged
orbitcowboy merged 4 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_Fix11621
Apr 1, 2023
Merged

Fix #11621 FP functionConst when assigning init list#4895
orbitcowboy merged 4 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_Fix11621

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@a4d2178). Click here to learn what that means.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4895   +/-   ##
=======================================
  Coverage        ?   91.45%           
=======================================
  Files           ?      201           
  Lines           ?   110837           
  Branches        ?        0           
=======================================
  Hits            ?   101371           
  Misses          ?     9466           
  Partials        ?        0           
Flag Coverage Δ
unittests 91.45% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/checkclass.cpp 92.96% <100.00%> (ø)
test/testclass.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@firewave
Copy link
Copy Markdown
Collaborator

Needs to be rebased.

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

Can we merge this?

@pfultz2
Copy link
Copy Markdown
Contributor

pfultz2 commented Apr 1, 2023

LGTM

@orbitcowboy orbitcowboy merged commit 7503aca into cppcheck-opensource:main Apr 1, 2023
@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Apr 1, 2023

Fails in trunk because there was already a test with that name. Fix in #4927.

@chrchr-github chrchr-github deleted the chr_Fix11621 branch May 22, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants