Skip to content

Update constVariable IDs for references and pointers#4904

Merged
danmar merged 4 commits intocppcheck-opensource:mainfrom
pfultz2:const-var-id
Apr 7, 2023
Merged

Update constVariable IDs for references and pointers#4904
danmar merged 4 commits intocppcheck-opensource:mainfrom
pfultz2:const-var-id

Conversation

@pfultz2
Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 commented Mar 20, 2023

Since we warn for local variables as well as references and pointers using a different ID will help users globally suppress the warnings.

@firewave
Copy link
Copy Markdown
Collaborator

Please add a releasenotes.txt entry as this might be a breaking change for some users.

@chrchr-github
Copy link
Copy Markdown
Collaborator

It seems that constParameter and constVariable now only refer to arrays. Maybe this could be made explicit in the name of the ID?

@pfultz2
Copy link
Copy Markdown
Contributor Author

pfultz2 commented Apr 7, 2023

It seems that constParameter and constVariable now only refer to arrays. Maybe this could be made explicit in the name of the ID?

We may expand this in the future, so I dont see a need to make a seperate ID for it.

@danmar danmar merged commit 93b4de3 into cppcheck-opensource:main Apr 7, 2023
@pfultz2 pfultz2 deleted the const-var-id branch April 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants