ValueFlow: Improve the starting point for uninitialized variables to find more uninitialized usages after many conditionals#4930
Merged
firewave merged 3 commits intocppcheck-opensource:mainfrom Apr 4, 2023
Conversation
Contributor
Author
|
@danmar @orbitcowboy @chrchr-github Any feedback? |
chrchr-github
approved these changes
Apr 4, 2023
Collaborator
chrchr-github
left a comment
chrchr-github
left a comment
There was a problem hiding this comment.
LGTM. I agree that those TODO test cases are odd.
There have been numerous changes already since the last release, so it becomes more difficult to assess the impact in daca,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test cases where the uninitialized variable is used in dead code have become a TODO. The test cases dont seem to be good examples of real-world code though. I think this can be addressed in a future PR.