Add missing rebinding trait to TaggedAllocator#5015
Closed
skeeto wants to merge 1 commit intocppcheck-opensource:mainfrom
skeeto:gcc-13-rebind
Closed
Add missing rebinding trait to TaggedAllocator#5015skeeto wants to merge 1 commit intocppcheck-opensource:mainfrom skeeto:gcc-13-rebind
skeeto wants to merge 1 commit intocppcheck-opensource:mainfrom
skeeto:gcc-13-rebind
Conversation
GCC 13 checks for this trait, and Cppcheck cannot be compiled without it. See: https://gcc.gnu.org/gcc-13/porting_to.html#alloc-rebind
Collaborator
|
thanks! there are some CI issues. i.e. clang-tidy says: /home/runner/work/cppcheck/cppcheck/lib/smallvector.h:46:5: error: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor,-warnings-as-errors] |
danmar
reviewed
May 11, 2023
| {} | ||
|
|
||
| template<class U> | ||
| TaggedAllocator(const TaggedAllocator<U, N>); |
Collaborator
There was a problem hiding this comment.
this constructor has no implementation right? Should it be marked with =delete?
Collaborator
There was a problem hiding this comment.
I can't test it but I wonder if this constructor should be removed and let the other constructor be used instead. What happens if you comment out line 45 and 46 and recompile?
This was referenced May 15, 2023
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
May 28, 2023
…l in patch to build w/ gcc 13 (see cppcheck-opensource/cppcheck#5015)
danmar
pushed a commit
that referenced
this pull request
Jun 13, 2023
Collaborator
|
#5146 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 13 checks for this trait, and Cppcheck cannot be compiled without it. See: https://gcc.gnu.org/gcc-13/porting_to.html#alloc-rebind