Skip to content

Refactoring: Break out loadLibraries() function. #5024

Merged
danmar merged 1 commit into
mainfrom
qml-refactoring-1
May 1, 2023
Merged

Refactoring: Break out loadLibraries() function. #5024
danmar merged 1 commit into
mainfrom
qml-refactoring-1

Conversation

@danmar
Copy link
Copy Markdown
Collaborator

@danmar danmar commented Apr 30, 2023

No functional change is intended.

This is a preparation to make qml handling work again

No functional change is intended.

This is a preparation to make qml handling work again
@danmar danmar force-pushed the qml-refactoring-1 branch from d1acc41 to 47800e0 Compare April 30, 2023 20:39
@firewave
Copy link
Copy Markdown
Collaborator

Here's a ticket regarding the duplicated builds for your PRs: open-telemetry/opentelemetry-python#1370. Unfortunately there's no solution for our case in there.

@firewave
Copy link
Copy Markdown
Collaborator

I think we need to limit the actions on push to the following branches:

on:
  push:
    branches:
      - main
      - 'releases/**'
  pull_request:

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#using-filters

So it will keep the current behavior on PRs but don't also don't fire on push

@danmar danmar merged commit d5fbd55 into main May 1, 2023
@danmar danmar deleted the qml-refactoring-1 branch May 1, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants