Conversation
| break; | ||
| prev = prev->link(); | ||
| } | ||
| if (prev->str() == "new") |
Collaborator
There was a problem hiding this comment.
Does this need a check for cpp?
| if (Token::simpleMatch(tok->link(),"} [")) { | ||
| tok = tok->next(); | ||
| } else if (state.cpp && iscpp11init(tok)) { | ||
| } else if ((state.cpp && iscpp11init(tok)) || Token::simpleMatch(tok->previous(), "] {")) { |
Collaborator
There was a problem hiding this comment.
Shouldn't the new check be inside iscpp11init()?
Collaborator
Author
There was a problem hiding this comment.
It is not c++11 initialization
Collaborator
There was a problem hiding this comment.
int a[2] { 0, 0 }; isn't valid in either C or C++03, unless I'm missing something.
Collaborator
Author
There was a problem hiding this comment.
@chrchr-github Your example is not valid that is correct. The code we want to handle is for example:
auto p = new int*[2]{new int, new int};
So the code we want to handle is not a variable initialisation at all. There is no variable initialization in the RHS..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.