Typos and stilistic updates#5141
Typos and stilistic updates#5141danmar merged 9 commits intocppcheck-opensource:mainfrom longradix:main
Conversation
* Typo
* Typo
* Typo
* Typo
* Typo
* Typo * Syntax
* Typo
| isRemovedVoidParameter Has void parameter been removed? | ||
| isSplittedVarDeclComma Is this a comma changed to semicolon in a splitted variable declaration ('int a,b;' => 'int a; int b;') | ||
| isSplittedVarDeclEq Is this a '=' changed to semicolon in a splitted variable declaration ('int a=5;' => 'int a; a=5;') | ||
| isSplittedVarDeclComma Is this a comma changed to semicolon in a split variable declaration ('int a,b;' => 'int a; int b;') |
There was a problem hiding this comment.
Maybe we should change the names of the flags as well.
There was a problem hiding this comment.
Have knowledge of C, but not C++. Do some TODO processors need to be added somewhere?
There was a problem hiding this comment.
I just noticed that this is cppcheckdata.py and not a .cpp file. This just mirrors some code in token.h (which maybe should be changed at some point). Feel free to ignore my comment.
There was a problem hiding this comment.
For completeness: The flags in token.h are fIsSplitVarDeclComma and fIsSplitVarDeclEq (so not in sync with cppcheckdata.py, should be adapted), while the accessor functions are still called isSplittedVarDeclComma() and isSplittedVarDeclEq(), ugh...
|
Have we added your name in the AUTHORS yet? |
|
My contribution is insufficiently substantive to be acknowledged. |
3 participants
codespell