Skip to content

Fix 11721: False positive: constParameterReference with overloaded template function#5151

Merged
chrchr-github merged 9 commits intocppcheck-opensource:mainfrom
pfultz2:template-simplifier-sort-decls-for-const
Jun 17, 2023
Merged

Fix 11721: False positive: constParameterReference with overloaded template function#5151
chrchr-github merged 9 commits intocppcheck-opensource:mainfrom
pfultz2:template-simplifier-sort-decls-for-const

Conversation

@pfultz2
Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 commented Jun 13, 2023

No description provided.

@chrchr-github
Copy link
Copy Markdown
Collaborator

Would this also fix https://trac.cppcheck.net/ticket/11648?

@pfultz2
Copy link
Copy Markdown
Contributor Author

pfultz2 commented Jun 15, 2023

Would this also fix https://trac.cppcheck.net/ticket/11648?

No it wouldn't. It needs a little more tweaking to the sort to get that to work.

@pfultz2
Copy link
Copy Markdown
Contributor Author

pfultz2 commented Jun 15, 2023

Would this also fix https://trac.cppcheck.net/ticket/11648?

No it wouldn't. It needs a little more tweaking to the sort to get that to work.

Fixed.

Comment thread lib/templatesimplifier.cpp Outdated
Comment thread lib/templatesimplifier.cpp Outdated
Comment thread lib/templatesimplifier.cpp Outdated
Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github chrchr-github merged commit d6e3182 into cppcheck-opensource:main Jun 17, 2023
@pfultz2 pfultz2 deleted the template-simplifier-sort-decls-for-const branch June 17, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants