Skip to content

daca: filter checker results when there are syntaxError/unknownMacro/etc #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 1 commit into from
Jul 4, 2023
Merged

daca: filter checker results when there are syntaxError/unknownMacro/etc #5214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tools/donate_cpu_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,25 @@ def diff_results(ver1, results1, ver2, results2):
ret += ver2 + ' ' + r2[i2] + '\n'
i2 += 1

# if there are syntaxError/unknownMacro/etc then analysis stops.
# diffing normal checker warnings will not make much sense
bailout_ids = ('[syntaxError]', '[unknownMacro]')
has_bailout_id = False
for id in bailout_ids:
if (id in results1) or (id in results1):
has_bailout_id = True
if has_bailout_id:
def check_bailout(line):
for id in bailout_ids:
if line.endswith(id):
return True
return False
out = ''
for line in ret.split('\n'):
if check_bailout(line):
out += line + '\n'
ret = out

return ret


Expand Down