optimized pipe writing/reading and ErrorMessage serialization a bit#5279
Merged
firewave merged 4 commits intocppcheck-opensource:mainfrom Aug 13, 2023
Merged
optimized pipe writing/reading and ErrorMessage serialization a bit#5279firewave merged 4 commits intocppcheck-opensource:mainfrom
ErrorMessage serialization a bit#5279firewave merged 4 commits intocppcheck-opensource:mainfrom
Conversation
Collaborator
|
If behaviour is unchanged.. looks good to me. |
Collaborator
Author
It should. It is still a draft since I still want to add unit tests for those "invalid" characters in the XML. |
Collaborator
Author
|
The calls were added in e6f042d for a deserialization failure with a 0 byte. Will look into it. |
Collaborator
Author
|
I removed the part which "fixes" the XML as it breaks an existing test and appears to be necessary. Will tackle that in a different PR. |
danmar
approved these changes
Aug 12, 2023
chrchr-github
pushed a commit
that referenced
this pull request
Aug 21, 2023
…writing - fixes stray `\0` characters in output (#5354) This was introduced in #5279. We were transferring the terminating `\0` via the pipe and also added another one in the parsing. As we are now directly writing into a `std::string` these extra characters will now show up in it. So just get rid of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-D__GNUC__ --debug-warnings --template=daca2 --check-library -j2 ../test/testsymboldatabase.cppthis reduces the IR needed for serializing/writing to a third (down from ~17,000). On the reading side there is not much of an improvement. But this will help a lot with daca as we are generating and processing millions of errors.