avoid some redundant and unused settings in tests among other cleanups / added and used WARN_UNUSED attribute#5284
Merged
firewave merged 10 commits intocppcheck-opensource:mainfrom Aug 9, 2023
Conversation
firewave
changed the title
WARN_UNUSED attribute
firewave
changed the title
WARN_UNUSED attributeWARN_UNUSED attribute
Collaborator
Author
|
I filed https://trac.cppcheck.net/ticket/11856 about the false negative in |
firewave
force-pushed
the
settings-x
branch
2 times, most recently
from
23c809c to
e39c030
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for redundant settings cannot be enabled by default as we have cases where the values are configurable. It might be possible to clean up some of those and use immutable objects instead.