Revert "testrunner: use structs with designated initialization to pass options (#4975)"

[pfultz2]

This reverts commit 5d201c4. This causes compile errors on clang++-13:

cppcheck/test/testthreadexecutor.cpp:61:110: error: default member initializer for 'showtime' needed within definition of enclosing class 'TestThreadExecutor' outside of member functions
    void check(unsigned int jobs, int files, int result, const std::string &data, const CheckOptions &opt = {}) {
                                                                                                             ^
cppcheck/test/testthreadexecutor.cpp:52:24: note: default member initializer declared here
        SHOWTIME_MODES showtime = SHOWTIME_MODES::SHOWTIME_NONE;
                       ^
cppcheck/test/testthreadexecutor.cpp:61:103: warning: unused parameter 'opt' [-Wunused-parameter]
    void check(unsigned int jobs, int files, int result, const std::string &data, const CheckOptions &opt = {}) {
                                                                                                      ^
cppcheck/test/testprocessexecutor.cpp:61:110: error: default member initializer for 'showtime' needed within definition of enclosing class 'TestProcessExecutor' outside of member functions
    void check(unsigned int jobs, int files, int result, const std::string &data, const CheckOptions &opt = {}) {
                                                                                                             ^
cppcheck/test/testprocessexecutor.cpp:52:24: note: default member initializer declared here
        SHOWTIME_MODES showtime = SHOWTIME_MODES::SHOWTIME_NONE;
                       ^
cppcheck/test/testprocessexecutor.cpp:61:103: warning: unused parameter 'opt' [-Wunused-parameter]
    void check(unsigned int jobs, int files, int result, const std::string &data, const CheckOptions &opt = {}) {
                                                                                                      ^
cppcheck/test/testsingleexecutor.cpp:72:91: error: default member initializer for 'showtime' needed within definition of enclosing class 'TestSingleExecutorBase' outside of member functions
    void check(int files, int result, const std::string &data, const CheckOptions &opt = {}) {
                                                                                          ^
cppcheck/test/testsingleexecutor.cpp:67:24: note: default member initializer declared here
        SHOWTIME_MODES showtime = SHOWTIME_MODES::SHOWTIME_NONE;
                       ^
cppcheck/test/testsingleexecutor.cpp:72:84: warning: unused parameter 'opt' [-Wunused-parameter]
    void check(int files, int result, const std::string &data, const CheckOptions &opt = {}) {
                                                                                   ^

I revert this for now, until a better solution can be found.

[pfultz2]

I found a workaround in #5297. So this may not be needed.

[firewave]

That's what I added the noexcept workaround for. So older Clang behaves like GCC 4.8.

[pfultz2]

That's what I added the noexcept workaround for. So older Clang behaves like GCC 4.8.

Yea that still didnt fix the issue for clang++-13 on ubuntu.

[firewave]

Closing as it is superseded by #5297.