got rid of duplicated file/directory existence implementations / improved errorhandling and testing of FileLister

[firewave]

No description provided.

[grawlinson]

Hi, this particular commit causes an issue when packaging 2.12.0 for Arch Linux.

It seems to hang indefinitely on TestFileLister, testsuite run shown below (had to Ctrl+C to exit process):

Test64BitPortability:.......
TestAnalyzerInformation:.
TestAssert:.....
TestAstUtils:..........
TestAutoVariables:...................................................................................................
TestBool:.................................
TestBoost:.
TestBufferOverrun:.............................................................................................................................................................................................
TestCharVar:...
TestClangImport:...............................................................................................
TestClass:.......................................................................................................................................................................................
TestCmdlineParser:.............................................................................................................................................................................................
TestColor:.
TestCondition:...................................................................
TestConstructors:........................................................................................................................................................
TestCppcheck:.
TestErrorLogger:.....................
TestExceptionSafety:.....................
TestFileLister:.

It could be because we build packages using systemd-nspawn, I thought it may be useful for cppcheck developers to know this.

[firewave]

@grawlinson Thanks for pointing this out. I actually encountered this locally in one of my installations but didn't get around to check and then I injured myself and forgot about it. I will look into this over the weekend.

Also please run testrunner with -q to verify the actual test which is causing this.

As a workaround you can simply disable the test. It was not executed in all cases before since it required a certain root directoy. I added a traversal hack for that which obviously ended up in an endless loop.

[firewave]

I am not able to reproduce this (I actually only encountered this once).

The issue is with TestFileLister::recursiveAddFiles() within the calling of findBaseDir() which is walking up the current directory until it hits our root folder. It does this by checking for the existence of the .github folder. So this issue should only occur if the build folder is outside of the source folder or the .github folder was removed. I guess the first case is very likely for packages.

We need to rewrite the test (there's already a TODO about it). I filed https://trac.cppcheck.net/ticket/11993#comment:1 about this.

[grawlinson]

Ah, this will be because of cmake -B build -S source where build directory is deliberately placed outside of the source directory.