Fix 11887: FP knownPointerToBool with const_cast#5357
Merged
chrchr-github merged 2 commits intocppcheck-opensource:mainfrom Aug 22, 2023
Merged
Fix 11887: FP knownPointerToBool with const_cast#5357chrchr-github merged 2 commits intocppcheck-opensource:mainfrom
chrchr-github merged 2 commits intocppcheck-opensource:mainfrom
Conversation
| if (Token::simpleMatch(tok, "<") && tok->link()) // don't write false positives when templates are used | ||
| // don't write false positives when templates are used or inside of asserts or non-evaluated contexts | ||
| if (tok->link() && (Token::simpleMatch(tok, "<") || | ||
| Token::Match(tok->previous(), "static_assert|assert|ASSERT|sizeof|decltype ("))) { |
Collaborator
There was a problem hiding this comment.
We should probably make a helper function for that. We already have isUnevaluatedOperator() and isUnevaluated() (2x) in various places.
Collaborator
There was a problem hiding this comment.
And there also is isSizeOfEtc().
Contributor
Author
There was a problem hiding this comment.
Well this is checking for unevaluated and for asserts.
Collaborator
There was a problem hiding this comment.
Seems like our checks for asserts aren't consistent everywhere either.
danmar
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.