Unified checks for unevaluated context#5362
Merged
chrchr-github merged 2 commits intocppcheck-opensource:mainfrom Aug 23, 2023
Merged
Unified checks for unevaluated context#5362chrchr-github merged 2 commits intocppcheck-opensource:mainfrom
chrchr-github merged 2 commits intocppcheck-opensource:mainfrom
Conversation
pfultz2
reviewed
Aug 22, 2023
| bool isUnevaluated(const Token *tok) | ||
| { | ||
| return Token::Match(tok, "sizeof|typeof|offsetof|decltype|__typeof__ ("); | ||
| return Token::Match(tok, "alignof|_Alignof|_alignof|__alignof|__alignof__|decltype|offsetof|sizeof|typeid|typeof|__typeof__ ("); |
Contributor
There was a problem hiding this comment.
This should be tok->previous() so we can also skip template parameters as well.
Collaborator
Author
There was a problem hiding this comment.
How will that work at every call site? Do you mean something like x<decltype(y)>?
Contributor
There was a problem hiding this comment.
I mean something like A<x == y> or A<x + y>.
Collaborator
Author
There was a problem hiding this comment.
Okay, but none of the code was even trying to do that, so I'd rather not add it in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.