Fix use-after-free crash when using --clang#5367
Merged
chrchr-github merged 3 commits intocppcheck-opensource:mainfrom Aug 28, 2023
Merged
Fix use-after-free crash when using --clang#5367chrchr-github merged 3 commits intocppcheck-opensource:mainfrom
chrchr-github merged 3 commits intocppcheck-opensource:mainfrom
Conversation
Collaborator
yes unfortunately. In my opinion it's highly experimental still :-( |
danmar
reviewed
Aug 24, 2023
| return &argumentList[num]; | ||
| if (num < argumentList.size()) { | ||
| auto it = argumentList.begin(); | ||
| std::advance(it, num); |
Collaborator
There was a problem hiding this comment.
I don't understand.. is this safer or faster in some way?
Collaborator
Author
There was a problem hiding this comment.
How would you do it with a std::list?
Collaborator
There was a problem hiding this comment.
ok understood.. it seems unfortunate to use a std::list but not sure how to solve it properly with the vector. :-(
Collaborator
Author
|
Filed https://trac.cppcheck.net/ticket/11895 for the FP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still ran into an assert failure in
Tokenizer::hasIfdef(), since some checks assume that the tokenizer is always present. Seems like clangimport is yet another rogue under-tested feature...