Skip to content

Fixed #11907 (False positive: uninitialized member (mutable member, const method call)) #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 2 commits into from
Sep 1, 2023
Merged

Fixed #11907 (False positive: uninitialized member (mutable member, const method call)) #5384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8cf9d
Fixed #11907 (False positive: uninitialized member (mutable member, c…
danmar Aug 31, 2023
ed6f5bb
shadow variable
danmar Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,14 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
else if (!member->isConst() && !member->isStatic()) {
assignAllVar(usage);
}

// const method, assume it assigns all mutable members
else if (member->isConst()) {
for (Usage& i: usage) {
if (i.var->isMutable())
i.assign = true;
}
}
}

// not member function
Expand Down
13 changes: 13 additions & 0 deletions test/testconstructors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ class TestConstructors : public TestFixture {
TEST_CASE(initvar_chained_assign); // BUG 2270433
TEST_CASE(initvar_2constructors); // BUG 2270353
TEST_CASE(initvar_constvar);
TEST_CASE(initvar_mutablevar);
TEST_CASE(initvar_staticvar);
TEST_CASE(initvar_brace_init);
TEST_CASE(initvar_union);
Expand Down Expand Up @@ -1194,6 +1195,18 @@ class TestConstructors : public TestFixture {
}


void initvar_mutablevar() {
check("class Foo {\n"
"public:\n"
" Foo() { update(); }\n"
"private:\n"
" void update() const;\n"
" mutable int x;\n"
"};");
ASSERT_EQUALS("", errout.str());
}


void initvar_staticvar() {
check("class Fred\n"
"{\n"
Expand Down