added CMake option EXTERNALS_AS_SYSTEM to treat external includes as SYSTEM ones

[firewave]

Although these files are part of our repo changes are being done via their original projects so it might make sense to treat these as system includes for some people instead of local ones.

[danmar]

This is probably something that it's best to write a separate trac ticket about. It's intended as an improvement for package maintainers right?

[firewave]

This is probably something that it's best to write a separate trac ticket about. It's intended as an improvement for package maintainers right?

Maybe. I assume there might be platforms at some point which do want to suppress this.
Nobody requested it, but in the past I have been flip-flopping about this and so I made it an option.

[danmar]

This is probably something that it's best to write a separate trac ticket about. It's intended as an improvement for package maintainers right?

Maybe. I assume there might be platforms at some point which do want to suppress this. Nobody requested it, but in the past I have been flip-flopping about this and so I made it an option.

Okay.. I believe a ticket would be good.. I think we (including myself) should be better on creating tickets.

It's not required to create tickets for refactorings or pure-CI changes.

Do you have a trac account?

[firewave]

Okay.. I believe a ticket would be good.. I think we (including myself) should be better on creating tickets.

It's not required to create tickets for refactorings or pure-CI changes.

Love that. We should include links to the Trac milestones in the GitHub tag descriptions.

[danmar]

Okay.. I believe a ticket would be good.. I think we (including myself) should be better on creating tickets.
It's not required to create tickets for refactorings or pure-CI changes.

Love that. We should include links to the Trac milestones in the GitHub tag descriptions.

👍

I am not sure what you mean with "Github tag descriptions".

[firewave]

I am not sure what you mean with "Github tag descriptions".

https://github.com/danmar/cppcheck/releases/tag/2.11 should link to https://trac.cppcheck.net/milestone/2.11 and so on

[danmar]

I am not sure what you mean with "Github tag descriptions".

https://github.com/danmar/cppcheck/releases/tag/2.11 should link to https://trac.cppcheck.net/milestone/2.11 and so on

you mean that the text should contain a link to the corresponding trac milestone? or is there some other way to link it? yes that link sounds reasonable anyway. 👍

[danmar]

I assumed this can wait until after the release.