do not pass POD types by reference (based on clazy function-args-by-value check)

[firewave]

No description provided.

[firewave]

I already filed https://trac.cppcheck.net/ticket/11880 about detecting this ourselves.

[firewave]

The naming-var inconsistency is already tracked in https://trac.cppcheck.net/ticket/11210.

[danmar]

how do we prevent that clazy is executed something like this perhaps?

#ifdef __clazy__
#error Do not run clazy
#endif

?

isn't it better that arguments are const, how does that hurt?

[firewave]

how do we prevent that clazy is executed something like this perhaps?

#ifdef __clazy__
#error Do not run clazy
#endif

No idea.

isn't it better that arguments are const, how does that hurt?

See #5388 (comment).

[danmar]

I do not feel sure about removing constness from arguments. But at the same time I'm not sure if I would want to enforce constness everywhere neither.

[firewave]

I do not feel sure about removing constness from arguments.

I would have kept it but then we should have cleaned up the headers to avoid potential confusion. But as these are POD types it should be clear but only if you have an IDE with hints (which is not a given). But as you see, we were not treating them as such.

But at the same time I'm not sure if I would want to enforce constness everywhere neither.

Since it is just POD types there's no strings attached. Everything else is a whole can of worms which need proper tooling support which approaches it from multiple angles at once or you will end up with potentially suboptimal code you will never detect.