Skip to content

pre-release commits for 2.12#5405

Merged
danmar merged 4 commits intocppcheck-opensource:mainfrom
cppchecksolutions:release-tweaks
Sep 6, 2023
Merged

pre-release commits for 2.12#5405
danmar merged 4 commits intocppcheck-opensource:mainfrom
cppchecksolutions:release-tweaks

Conversation

@danmar
Copy link
Copy Markdown
Collaborator

@danmar danmar commented Sep 4, 2023

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Sep 4, 2023

We should merge the crash fixes before release.

We also still have a sizable performance regression (13% on average) which I am not sure we are already tracking. I will take a look tomorrow.

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Sep 5, 2023

We are dealing with at least two performance regressions. That makes bisecting a bit more difficult.

The more recent one is https://trac.cppcheck.net/ticket/11921. And the prior one appears to be https://trac.cppcheck.net/ticket/11876.

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Sep 6, 2023

I think I can't delay the release much longer now unfortunately. The daca crash report looks reasonable however it's unfortunate we have open crash tickets..

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Sep 6, 2023

I think I can't delay the release much longer now unfortunately

I assume there is no open PR with some crash fix right now.

@danmar danmar merged commit 48a7a43 into cppcheck-opensource:main Sep 6, 2023
@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Sep 6, 2023

I assume there is no open PR with some crash fix right now.

Yes. And I think the performance regressions are being tracked. I pulled a copy of the report for post mortem.

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Sep 6, 2023

Yes. And I think the performance regressions are being tracked. I pulled a copy of the report for post mortem.

ok. I plan to tag a "release candidate 1" asap. I am not sure how to define the version number for 2.12-rc1 properly in cmake/versions.cmake etc.. but for now I am thinking that I will set it to 2.12.0... I will git tag it as "2.12-rc1" to start with and if it works well in testing I will git tag it as "2.12.0" later..

if you have better ideas do not hesitate to share it with me :-)

I set the versions here: 6fc2d80

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Sep 7, 2023

#4751 (comment) for a prior suggestion on how to do the versioning.

@danmar danmar deleted the release-tweaks branch September 10, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants