Fix #12002 (Filelister: Unclear error 'finding files failed (error: 3)')

[danmar]

No description provided.

[firewave]

LGTM.

The error code should be printed as a string as well. As I was not sure if we will ever hit this error so I did not add the functionality yet. I think it requires a call to Windows API function FormatMessage() which used to be a bit fiddly IIRC. Maybe there's an easier approach. It's been a while. I might do this with some strerror() change I have locally though.

[firewave]

FYI 3 is ERROR_PATH_NOT_FOUND.

So we either ignore this as the configuration might be a catch-all.
Or we report it as an proper error as it might be a configuration error and files are being omitted.

Either would make sense. I would go for the second option though.

Some short tests show that we ignore even no-existing files you specify on the command-line and only bail out when no file at all is found to analyze. Which is not optimal.

[danmar]

The error code should be printed as a string as well.

Yes I would like that. But I don't know how to reproduce this issue and therefore I don't know how to test if it works.

I also looked at FormatMessage and it looks non-trivial to use to me.

[danmar]

Either would make sense. I would go for the second option though.

Yes spontanously I also feel we should report it as a proper error. I want to understand what the problem is for the user though. Is it for some reason expected to skip some special folder..

At least the configuration did not look very strange to me at first glance.

[firewave]

It is just a missing path or a typo in it:

cppcheck somepath/*
[...]
cppcheck: finding files failed (error: 3)
cppcheck: error: could not find or open any of the paths given.

Yes spontanously I also feel we should report it as a proper error.

👍

I also looked at FormatMessage and it looks non-trivial to use to me.

I can take a look.