Fix #12036 FN knownConditionTrueFalse comparing enum with number

[chrchr-github]

No description provided.

[chrchr-github]

Any reason not to warn for known comparisons with enum values?

[firewave]

Any reason not to warn for known comparisons with enum values?

Please elaborate.

[chrchr-github]

Well I changed those test cases where we previously wouldn't warn for e.g. if (Four == 4) {}.
I see no reason not to warn, since we do so for integer constants as well.

[firewave]

Well I changed those test cases where we previously wouldn't warn for e.g. if (Four == 4) {}. I see no reason not to warn, since we do so for integer constants as well.

Alright, I thought I missed something.

I don't see any reason not to warn either.