Skip to content

Fix #12150 FP uninitialized member array, initialized in range for loop #5627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Nov 6, 2023
Merged

Fix #12150 FP uninitialized member array, initialized in range for loop #5627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf481e1
Fix #12150 FP uninitialized member array, initialized in range for loop
chrchr-github Nov 6, 2023
7493a57
Format
chrchr-github Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,11 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
assignVar(usage, ftok->next()->varId());
} else if (Token::Match(ftok, "* this . %name% =")) {
assignVar(usage, ftok->tokAt(3)->varId());
} else if (astIsRangeBasedForDecl(ftok)) {
if (const Variable* rangeVar = ftok->astParent()->astOperand1()->variable()) {
if (rangeVar->isReference() && !rangeVar->isConst())
assignVar(usage, ftok->varId());
}
}

// The functions 'clear' and 'Clear' are supposed to initialize variable.
Expand Down
15 changes: 15 additions & 0 deletions test/testconstructors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ class TestConstructors : public TestFixture {
TEST_CASE(uninitVarArray8);
TEST_CASE(uninitVarArray9); // ticket #6957, #6959
TEST_CASE(uninitVarArray10);
TEST_CASE(uninitVarArray11);
TEST_CASE(uninitVarArray2D);
TEST_CASE(uninitVarArray3D);
TEST_CASE(uninitVarCpp11Init1);
Expand Down Expand Up @@ -3180,6 +3181,20 @@ class TestConstructors : public TestFixture {
errout.str());
}

void uninitVarArray11() {
check("class C {\n" // #12150
"private:\n"
" int buf[10];\n"
"public:\n"
" C() {\n"
" for (int& i : buf)\n"
" i = 0;\n"
" }\n"
"};\n");

ASSERT_EQUALS("", errout.str());
}

void uninitVarArray2D() {
check("class John\n"
"{\n"
Expand Down