Fix #12166 debug: varid0 with reference typedef

[chrchr-github]

Why do we even split any declarations in the first place?

[danmar]

Why do we even split any declarations in the first place?

It would be better that we don't split the declarations and we can look at this later someday.

The reason; we did not have ast and valueflow to start with, then it made sense to split. we wanted to canonicalize the code as much as possible so there was as little variations as possible for the checkers to deal with. This meant they didn't have to deal with variable initialization syntax.

Now we have ast and valueflow and the logic is not put in the checkers anymore.. this simplification is not very helpful anymore. I would be happy to remove it.

[chrchr-github]

Thanks for the explanation, I figured it was from the old days.