Don't report checkLibraryUseIgnore for known functions (refs #7719)#5664
Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom Nov 16, 2023
Merged
Conversation
firewave
reviewed
Nov 15, 2023
| " int* p = malloc(4);\n" | ||
| " bar(p);\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS("", errout.str()); |
Collaborator
There was a problem hiding this comment.
Something off-topic. I wonder if we also should start adding more negative/positive tests in addition to simply testing for the regression.
I was looking into removing some unnecessary settings in the unit tests but it might not be safe to remove some of those as we might just check for a message not appearing. If that result relies on an option/library being specified the tests would still pass but the message would not be absent because of the fix but because the code in question is never executed.
Collaborator
Author
There was a problem hiding this comment.
Well TestLeakAutoVar sets the checkLibrary flag, and there are tests which check the presence of that warning.
danmar
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.