Skip to content

iwyu.yml: use OpenSUSE to get latest include-what-you-use / cleaned up includes#5673

Merged
firewave merged 2 commits intocppcheck-opensource:mainfrom
firewave:iwyu-latest
Mar 8, 2024
Merged

iwyu.yml: use OpenSUSE to get latest include-what-you-use / cleaned up includes#5673
firewave merged 2 commits intocppcheck-opensource:mainfrom
firewave:iwyu-latest

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Nov 17, 2023

To keep with the program we have to bunny-hop to yet another distro to get the latest version of include-what-you-use.

@firewave firewave force-pushed the iwyu-latest branch 2 times, most recently from 3d68463 to 66479db Compare November 17, 2023 02:10
@firewave firewave changed the title iwyu.yml: use OpenSUSE to get latest include-what-you-use iwyu.yml: use OpenSUSE to get latest include-what-you-use / cleaned up includes Nov 17, 2023
@firewave
Copy link
Copy Markdown
Collaborator Author

There's several false negatives (or true positives) I still have to look into before we can move to the newer version.

@firewave firewave force-pushed the iwyu-latest branch 2 times, most recently from a49a84b to 20b828b Compare January 7, 2024 17:16
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Mar 4, 2024

I filed some tickets upstream:
include-what-you-use/include-what-you-use#1478
include-what-you-use/include-what-you-use#1479

There's also several cases where it suggests to add STL headers which are apparently unnecessary (mostly string). I have not looked into those yet as I lack a local system with the version in question.

@firewave firewave marked this pull request as ready for review March 4, 2024 11:48
Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit f465dc5 into cppcheck-opensource:main Mar 8, 2024
@firewave firewave deleted the iwyu-latest branch March 8, 2024 12:29
@firewave firewave mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants