#12158: improve check: variableScope is not reported when there is el…#5758
Merged
Merged
Conversation
danmar
added
the
merge-after-next-release
danmar
reviewed
Dec 13, 2023
| " if ( value > 100U ) { }\n" | ||
| " else if( value > 50U ) { }\n" | ||
| " else{\n" | ||
| " for( i = 0U; i < 5U; i++ ) {}" |
Collaborator
There was a problem hiding this comment.
@olabetskyi nothing is wrong here but please add newline..
danmar
reviewed
Dec 13, 2023
Collaborator
There was a problem hiding this comment.
@olabetskyi I assume no warning will be written for the code below.. feel free to investigate how we can warn for this code:
void f( uint32_t value ) {
uint32_t i = 0U;
if ( value > 100U ) { }
else {
if( value > 50U ) { }
else {
for( i = 0U; i < 5U; i++ ) {}
}
}
}
Collaborator
Author
|
@danmar I've added your example to tests and it was caught as expected. Bacuse for the provided solution there is no difference between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variableScope is not reported when there is else if