mitigated some modernize-use-auto clang-tidy warnings#5838
Merged
firewave merged 2 commits intocppcheck-opensource:mainfrom May 24, 2024
Merged
mitigated some modernize-use-auto clang-tidy warnings#5838firewave merged 2 commits intocppcheck-opensource:mainfrom
modernize-use-auto clang-tidy warnings#5838firewave merged 2 commits intocppcheck-opensource:mainfrom
Conversation
Collaborator
Author
|
This produces a lot of warning for iterators. We could switch to It will most likely not be of any harm but I would prefer to enforce the constness if possible. That could be done using As the iterator case already yields a separate message this is treated as a different group of issues. So I will file a ticket about making this configurable. |
6b57ec3 to
c31b929
Compare
modernize-use-auto clang-tidy checkmodernize-use-auto clang-tidy warnings
Collaborator
Author
|
I filed llvm/llvm-project#84324 upstream about the iterator issue. |
4766a17 to
b4d5fe8
Compare
danmar
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.