Fix #12287 FP uninitvar when passing address to function#5899
Merged
orbitcowboy merged 2 commits intocppcheck-opensource:mainfrom Jan 19, 2024
Merged
Fix #12287 FP uninitvar when passing address to function#5899orbitcowboy merged 2 commits intocppcheck-opensource:mainfrom
orbitcowboy merged 2 commits intocppcheck-opensource:mainfrom
Conversation
pfultz2
reviewed
Jan 20, 2024
| " return n;\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS("[test.cpp:4] -> [test.cpp:1]: (warning) Uninitialized variable: i\n", errout.str()); | ||
| ASSERT_EQUALS("", errout.str()); |
Contributor
There was a problem hiding this comment.
This should be caught be ValueFlow.
Collaborator
Author
There was a problem hiding this comment.
Well, it is, and then we bail because we don't have a function isVariableWrittenBeforeReadInFunctionCall().
Please feel free to improve on this fix.
pfultz2
reviewed
Jan 20, 2024
| " bool b;\n" | ||
| " f(&b);\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS("", errout.str()); |
Contributor
There was a problem hiding this comment.
There should be a valueflow test to make sure the valueflow for p in *p = true is not set to an uninitialized value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.