testrunner: reduced usage of mutable Settings / some cleanups#5909
Conversation
firewave
force-pushed
the
symdb-2
branch
2 times, most recently
from
85c54f4 to
1287363
Compare
| // Clear the error log | ||
| errout.str(""); | ||
|
|
||
| Preprocessor preprocessor(settings0); |
There was a problem hiding this comment.
This was relying on the modifications checkVirtualDestructor() did.
| } | ||
|
|
||
| { | ||
| Settings s = settingsBuilder().checkUnusedTemplates().build(); |
There was a problem hiding this comment.
Unnecessary as checkUnusedTemplates is true by default.
There was a problem hiding this comment.
This now uses _settings which has std.cfg loaded but I do think this is not an issue.
| } | ||
|
|
||
| void forwardAndUsed() { | ||
| Settings s = settingsBuilder().checkUnusedTemplates().build(); |
There was a problem hiding this comment.
Unnecessary as checkUnusedTemplates is true by default.
There was a problem hiding this comment.
This now uses _settings which has std.cfg loaded but I do think this is not an issue.
| const char *code; | ||
| std::vector<std::string> lifetimes; | ||
|
|
||
| LOAD_LIB_2(settings.library, "std.cfg"); |
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
|
|
||
| // ~ | ||
| code = "x = ~0U;"; | ||
| PLATFORM(settings.platform, Platform::Type::Native); // ensure platform is native |
There was a problem hiding this comment.
Obsolete as we now default to Native on all platforms.
| void valueFlowContainerSize() { | ||
| const char *code; | ||
|
|
||
| LOAD_LIB_2(settings.library, "std.cfg"); |
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
| { | ||
| const char* code; | ||
|
|
||
| LOAD_LIB_2(settings.library, "std.cfg"); |
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
| void valueFlowDynamicBufferSize() { | ||
| const char *code; | ||
|
|
||
| LOAD_LIB_2(settings.library, "std.cfg"); |
There was a problem hiding this comment.
Unnecessary as std.cfg is already loaded in settings.
2 participants
No description provided.