CheckIO: make sure ArgumentInfo::tempToken is sufficiently initialized#5932
Merged
Conversation
danmar
reviewed
Feb 4, 2024
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
did you see some false positives or compiler warnings or something? if false positives.. a unit test can be added.. but I assume you would have added it then.
Collaborator
Author
|
I have no idea how to even trigger that as the code is so complex. It was just inconsistent and will help towards avoiding those asserts in #5853. |
Collaborator
Author
|
I didn't actually answer your question. I came across this by reviewing code. The follow-up PR will show that a test is partially unnecessary. |
Collaborator
Author
|
Anything still to do here? This is holding up a lot of follow-up PRs... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.