Skip to content

Fix #12446 FN cstyleCast with scope operator #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Feb 19, 2024
Merged

Fix #12446 FN cstyleCast with scope operator #5989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
442aeb4
Fix #12446 FN cstyleCast with scope operator
chrchr-github Feb 16, 2024
40336c4
Fix
chrchr-github Feb 16, 2024
8a0acf8
Skip template arguments
chrchr-github Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,13 +313,26 @@ void CheckOther::warningOldStylePointerCast()
tok = scope->bodyStart;
for (; tok && tok != scope->bodyEnd; tok = tok->next()) {
// Old style pointer casting..
if (!Token::Match(tok, "( const|volatile| const|volatile|class|struct| %type% * *| *| const|&| ) (| %name%|%num%|%bool%|%char%|%str%|&"))
if (tok->str() != "(")
continue;
const Token* castTok = tok->next();
while (Token::Match(castTok, "const|volatile|class|struct|union|%type%|::")) {
castTok = castTok->next();
if (Token::simpleMatch(castTok, "<") && castTok->link())
castTok = castTok->link()->next();
}
if (castTok == tok->next() || !Token::simpleMatch(castTok, "*"))
continue;
while (Token::Match(castTok, "*|const|&"))
castTok = castTok->next();
if (!Token::Match(castTok, ") (| %name%|%num%|%bool%|%char%|%str%|&"))
continue;

if (Token::Match(tok->previous(), "%type%"))
continue;

// skip first "const" in "const Type* const"
while (Token::Match(tok->next(), "const|volatile|class|struct"))
while (Token::Match(tok->next(), "const|volatile|class|struct|union"))
tok = tok->next();
const Token* typeTok = tok->next();
// skip second "const" in "const Type* const"
Expand Down
16 changes: 16 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,6 +1895,22 @@ class TestOther : public TestFixture {
ASSERT_EQUALS("[test.cpp:2]: (style) C-style pointer casting\n"
"[test.cpp:3]: (style) C-style pointer casting\n",
errout.str());

// #12446
checkOldStylePointerCast("namespace N { struct S {}; }\n"
"union U {\n"
" int i;\n"
" char c[4];\n"
"};\n"
"void f(void* p) {\n"
" auto ps = (N::S*)p;\n"
" auto pu = (union U*)p;\n"
" auto pv = (std::vector<int>*)(p);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:7]: (style) C-style pointer casting\n"
"[test.cpp:8]: (style) C-style pointer casting\n"
"[test.cpp:9]: (style) C-style pointer casting\n",
errout.str());
}

#define checkInvalidPointerCast(...) checkInvalidPointerCast_(__FILE__, __LINE__, __VA_ARGS__)
Expand Down