Skip to content

Fix #12457: use essential type category in 21.16 #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 1 commit into from
Feb 27, 2024
Merged

Fix #12457: use essential type category in 21.16 #6015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/misra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3876,7 +3876,7 @@ def misra_21_16(self, cfg):
continue
if arg.valueType.pointer > 1:
continue
if arg.valueType.sign in ('unsigned', 'signed'):
if getEssentialTypeCategory(arg) in ('unsigned', 'signed', 'bool'):
continue
if arg.valueType.isEnum():
continue
Expand Down
22 changes: 20 additions & 2 deletions addons/test/misra/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ static int misra_8_2_g ( /* comment */ ); // 8.2
static int misra_8_2_h ( /* comment 1 */ /* comment 2 */ ); // 8.2
static int misra_8_2_i ( /* comment */ void);
static int misra_8_2_j ( /* comment */ void /* comment */);
static int misra_8_2_k ( //
static int misra_8_2_k ( //
void);
static int misra_8_2_l ( // 8.2
);
Expand Down Expand Up @@ -731,7 +731,7 @@ static void misra_10_4(u32 x, s32 y) {
z = x + y; //10.4
z = (a == misra_10_4_A3) ? x : y; //10.4
z = (a == misra_10_4_A3) ? y : y; // no-warning

// #10499
const char buf[10] = {0};
if ('0' == buf[x]) // no-warning
Expand Down Expand Up @@ -1977,6 +1977,24 @@ static void misra_21_16_f1(struct misra_21_16_S *s1, struct misra_21_16_S *s2) {
static void misra_21_16_f2(char *x, char *y) {
(void)memcmp(x, y, 10); // 21.16
}
typedef enum { R21_16_A, R21_16_B} r21_16_enum;
static void misra_21_16_f3(void) {
int const a[2] = {0};
int const b[2] = {0};
(void)memcmp(a, b, 2); // no-warning
uint8_t const c[2] = {0};
uint8_t const d[2] = {0};
(void)memcmp(c, d, 2); // no-warning
bool const e[2] = {0};
bool const f[2] = {0};
(void)memcmp(e, f, 2); // no-warning
r21_16_enum const g[2] = {0};
r21_16_enum const h[2] = {0};
(void)memcmp(g, h, 2); // no-warning
char const i[2] = {0};
char const j[2] = {0};
(void)memcmp(i, j, 2); // 21.16
}

static void misra_21_19(void) {
char *s = setlocale(LC_ALL,0); // 21.19
Expand Down